Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1518843002: Use size_t for strlen() return value (Closed)

Created:
5 years ago by scroggo
Modified:
5 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@strlen
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/gl/egl/SkCreatePlatformGLContext_egl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1512753006 Patch 1

Messages

Total messages: 8 (3 generated)
scroggo
5 years ago (2015-12-10 19:37:24 UTC) #2
bsalomon
5 years ago (2015-12-10 20:46:45 UTC) #3
bsalomon
On 2015/12/10 20:46:45, bsalomon wrote: lgtm
5 years ago (2015-12-10 20:46:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518843002/1
5 years ago (2015-12-10 21:19:35 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 21:46:07 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9fba90979243501d2348d1539ad2bb0bdf411b5b

Powered by Google App Engine
This is Rietveld 408576698