Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1512753006: Remove unused CallStacker (Closed)

Created:
5 years ago by scroggo
Modified:
5 years ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unused CallStacker Found this while looking for uses of strlen (skbug.com/2810). This code was written by a former member of the team and is not used. BUG=skia:2810 Committed: https://skia.googlesource.com/skia/+/671c06f9798d44fcb1cff741880dff07fed71a36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1185 lines) Patch
D experimental/LightSymbolsUtil/Callstacker/Callstacker.sln View 1 chunk +0 lines, -20 lines 0 comments Download
D experimental/LightSymbolsUtil/Callstacker/Callstacker/Callstacker.cpp View 1 chunk +0 lines, -673 lines 0 comments Download
D experimental/LightSymbolsUtil/Callstacker/Callstacker/Callstacker.vcxproj View 1 chunk +0 lines, -90 lines 0 comments Download
D experimental/LightSymbolsUtil/Callstacker/Callstacker/Callstacker.vcxproj.filters View 1 chunk +0 lines, -36 lines 0 comments Download
D experimental/LightSymbolsUtil/Callstacker/Callstacker/Callstacker.vcxproj.user View 1 chunk +0 lines, -11 lines 0 comments Download
D experimental/LightSymbolsUtil/Callstacker/Callstacker/ReadMe.txt View 1 chunk +0 lines, -40 lines 0 comments Download
D experimental/LightSymbolsUtil/Callstacker/Callstacker/stdafx.h View 1 chunk +0 lines, -15 lines 0 comments Download
D experimental/LightSymbolsUtil/Callstacker/Callstacker/stdafx.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
D experimental/LightSymbolsUtil/Callstacker/Callstacker/targetver.h View 1 chunk +0 lines, -8 lines 0 comments Download
D experimental/LightSymbolsUtil/lightsymbols/helper.h View 1 chunk +0 lines, -65 lines 0 comments Download
D experimental/LightSymbolsUtil/lightsymbols/lightsymbols.h View 1 chunk +0 lines, -50 lines 0 comments Download
D experimental/LightSymbolsUtil/lightsymbols/lightsymbols.cc View 1 chunk +0 lines, -169 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512753006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512753006/1
5 years ago (2015-12-10 18:47:37 UTC) #2
scroggo
5 years ago (2015-12-10 18:47:53 UTC) #4
mtklein
lgtm
5 years ago (2015-12-10 18:56:17 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-10 19:13:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1512753006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1512753006/1
5 years ago (2015-12-10 19:27:21 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-10 19:28:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/671c06f9798d44fcb1cff741880dff07fed71a36

Powered by Google App Engine
This is Rietveld 408576698