Issue 151883005: Revert 248271 "Add a minimum required version to the webapp mani..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151883005: Revert 248271 "Add a minimum required version to the webapp mani..." (Closed)

Created:
6 years, 10 months ago by kareng

Modified:
6 years, 10 months ago

Reviewers:
weitao

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1817/src/

Visibility:
Public.

More Reviews

Description

Revert 248271 "Add a minimum required version to the webapp mani..." > Add a minimum required version to the webapp manifest to ensure that native messaging is supported. > > BUG=309844 > > Review URL: https://codereview.chromium.org/150423003 TBR=weitaosu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248344

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -6 lines)			Patch
M	remoting/webapp/appsv2.patch	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	remoting/webapp/host_native_messaging.js	View	2 chunks	+18 lines, -2 lines	0 comments	Download
M	remoting/webapp/manifest.json	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kareng

6 years, 10 months ago (2014-02-01 06:59:17 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r248344 (tree was closed).

Expand Messages | Collapse Messages