Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 150423003: Add a minimum required version to the webapp manifest to ensure that native messaging is supported. (Closed)

Created:
6 years, 10 months ago by weitao
Modified:
6 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Add a minimum required version to the webapp manifest to ensure that native messaging is supported. BUG=309844 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248271

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M remoting/webapp/appsv2.patch View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/webapp/host_native_messaging.js View 2 chunks +2 lines, -18 lines 0 comments Download
M remoting/webapp/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
weitao
PTAL
6 years, 10 months ago (2014-01-31 00:31:25 UTC) #1
Jamie
lgtm
6 years, 10 months ago (2014-01-31 01:35:10 UTC) #2
weitao
The CQ bit was checked by weitaosu@chromium.org
6 years, 10 months ago (2014-01-31 18:38:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/150423003/1
6 years, 10 months ago (2014-01-31 18:38:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/150423003/1
6 years, 10 months ago (2014-01-31 21:15:08 UTC) #5
commit-bot: I haz the power
Change committed as 248271
6 years, 10 months ago (2014-01-31 21:24:05 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 21:24:15 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-31 21:24:16 UTC) #8
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698