Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1518783002: Revert of autofill: switch autofill_regexes to RE2 library (Closed)

Created:
5 years ago by tfarina
Modified:
5 years ago
CC:
chromium-reviews, droger+watchlist_chromium.org, rouslan+autofill_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of autofill: switch autofill_regexes to RE2 library (patchset #16 id:300001 of https://codereview.chromium.org/1453193002/ ) Reason for revert: This caused a memory perf regression on android. BUG=568134 Original issue's description: > autofill: switch autofill_regexes to RE2 library > > This moves it away from using regex library from icu to the in-house re2 > library that is known to have a better performance and be much more > lightweight and much less verbose to write code. > > BUG=470065 > TEST=components_unittests --gtest_filter=*Autofill* > R=vabr@chromium.org,isherman@chromium.org > > Committed: https://crrev.com/2df535152b8023dc3dcbc7dd8c7f1a1e3d959e13 > Cr-Commit-Position: refs/heads/master@{#363835} TBR=isherman@chromium.org,vabr@chromium.org,estade@chromium.org,mathp@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=470065 Committed: https://crrev.com/09fbd7763570425e426178663a9549cd4579aa90 Cr-Commit-Position: refs/heads/master@{#364412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -173 lines) Patch
M components/autofill.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/address_field.cc View 15 chunks +60 lines, -44 lines 0 comments Download
M components/autofill/core/browser/autofill_regex_constants.cc View 8 chunks +10 lines, -18 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card_field.cc View 15 chunks +26 lines, -20 lines 0 comments Download
M components/autofill/core/browser/email_field.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/autofill/core/browser/form_field.h View 4 chunks +5 lines, -5 lines 0 comments Download
M components/autofill/core/browser/form_field.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M components/autofill/core/browser/form_field_unittest.cc View 2 chunks +56 lines, -34 lines 0 comments Download
M components/autofill/core/browser/name_field.cc View 6 chunks +16 lines, -11 lines 0 comments Download
M components/autofill/core/browser/phone_field.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M components/autofill/core/browser/validation.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/autofill/core/common/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M components/autofill/core/common/autofill_regexes.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/autofill/core/common/autofill_regexes.cc View 5 chunks +24 lines, -15 lines 0 comments Download
M components/autofill/core/common/autofill_regexes_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tfarina
Created Revert of autofill: switch autofill_regexes to RE2 library
5 years ago (2015-12-10 18:41:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518783002/1
5 years ago (2015-12-10 18:42:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 18:45:08 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-10 18:46:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09fbd7763570425e426178663a9549cd4579aa90
Cr-Commit-Position: refs/heads/master@{#364412}

Powered by Google App Engine
This is Rietveld 408576698