Adds MD ink ripple animations to buttons within location bar

chrome/browser/ui/views/toolbar/toolbar_view.cc

Index: chrome/browser/ui/views/toolbar/toolbar_view.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_view.cc b/chrome/browser/ui/views/toolbar/toolbar_view.cc
index d1624fcd5b4158d8c7e07c5873429a433d16dd82..2c127b7bd4f736baaa0dcb1a26f07754bb613172 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_view.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_view.cc
@@ -329,6 +329,16 @@ views::View* ToolbarView::GetTranslateBubbleAnchor() {
              : app_menu_button_;
 }
 
+void ToolbarView::OnBubbleCreatedForAnchor(views::View* anchor_view,
+                                           views::Widget* bubble_widget) {
+  if (bubble_widget &&
+      (anchor_view == location_bar()->star_view() ||
+       anchor_view == location_bar()->save_credit_card_icon_view() ||
+       anchor_view == location_bar()->translate_icon_view())) {

[Peter Kasting, 2016/01/28 20:42:12]

Nit: {} not necessary

[varkha, 2016/01/28 22:04:52]

I am used to the style guide allowing this[1] for complex conditions:
"conditional or loop statements with complex conditions or statements may be
more readable with curly braces." I think it helps keep track of the
indentation.

[1] https://google.github.io/styleguide/cppguide.html#Conditionals

[Peter Kasting, 2016/01/28 22:21:22]

Right, it's allowed if you want it.  Probably more c/b/ui/views/ code omits it
than has it but there's no real consistency to mandate.

+    bubble_widget->AddObserver(static_cast<BubbleIconView*>(anchor_view));
+  }
+}
+
 void ToolbarView::ExecuteExtensionCommand(
     const extensions::Extension* extension,
     const extensions::Command& command) {