Adds MD ink ripple animations to buttons within location bar

chrome/browser/ui/views/toolbar/toolbar_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/i18n/number_formatting.h"
@@ skipping 311 matching lines @@
              : app_menu_button_;
 }
 
 views::View* ToolbarView::GetTranslateBubbleAnchor() {
   views::View* translate_icon_view = location_bar()->translate_icon_view();
   return (translate_icon_view && translate_icon_view->visible())
              ? translate_icon_view
              : app_menu_button_;
 }
 
+void ToolbarView::OnBubbleCreatedForAnchor(views::View* anchor_view,
+                                           views::Widget* bubble_widget) {
+  if (bubble_widget &&
+      (anchor_view == location_bar()->star_view() ||
+       anchor_view == location_bar()->save_credit_card_icon_view() ||
+       anchor_view == location_bar()->translate_icon_view())) {

[Peter Kasting, 2016/01/28 20:42:12]

Nit: {} not necessary

[varkha, 2016/01/28 22:04:52]

I am used to the style guide allowing this[1] for complex conditions:
"conditional or loop statements with complex conditions or statements may be
more readable with curly braces." I think it helps keep track of the
indentation.

[1] https://google.github.io/styleguide/cppguide.html#Conditionals

[Peter Kasting, 2016/01/28 22:21:22]

Right, it's allowed if you want it.  Probably more c/b/ui/views/ code omits it
than has it but there's no real consistency to mandate.

+    bubble_widget->AddObserver(static_cast<BubbleIconView*>(anchor_view));
+  }
+}
+
 void ToolbarView::ExecuteExtensionCommand(
     const extensions::Extension* extension,
     const extensions::Command& command) {
   browser_actions_->ExecuteExtensionCommand(extension, command);
 }
 
 int ToolbarView::GetMaxBrowserActionsWidth() const {
   // The browser actions container is allowed to grow, but only up until the
   // omnibox reaches its minimum size. So its maximum allowed width is its
   // current size, plus any that the omnibox could give up.
@@ skipping 469 matching lines @@
 void ToolbarView::OnShowHomeButtonChanged() {
   Layout();
   SchedulePaint();
 }
 
 int ToolbarView::content_shadow_height() const {
   return GetLayoutConstant(
       (browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH) ?
           TOOLBAR_CONTENT_SHADOW_HEIGHT_ASH : TOOLBAR_CONTENT_SHADOW_HEIGHT);
 }