ui/views/controls/button/button.h - Issue 1518543002: Adds MD ink ripple animations to buttons within location bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/button.h

Issue 1518543002: Adds MD ink ripple animations to buttons within location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds MD ink ripple animations to buttons within location bar (reverted a bad change) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/browser_view.cc ('K') | « chrome/browser/ui/views/toolbar/toolbar_view.cc ('k') | ui/views/controls/image_view.h » ('j') | ui/views/widget/widget_observer_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/button/button.h

diff --git a/ui/views/controls/button/button.h b/ui/views/controls/button/button.h

index 0f1160b11f1c5563efb43f12ea17fb9fc0f4b8da..8b03be3c68e5548c780112cd074adf5962ab1fa3 100644

--- a/ui/views/controls/button/button.h

+++ b/ui/views/controls/button/button.h

@@ -8,6 +8,7 @@

#include "base/macros.h"

#include "ui/native_theme/native_theme.h"

#include "ui/views/view.h"

+#include "ui/views/widget/widget_observer_view.h"

namespace views {

@@ -26,7 +27,7 @@ class VIEWS_EXPORT ButtonListener {

// A View representing a button. Depending on the specific type, the button

// could be implemented by a native control or custom rendered.

-class VIEWS_EXPORT Button : public View {

+class VIEWS_EXPORT Button : public WidgetObserverView {

sadrul 2016/01/28 17:45:06 We shouldn't do this, of course.

varkha 2016/01/28 20:09:19 Done.

public:

~Button() override;