Adds MD ink ripple animations to buttons within location bar

chrome/browser/ui/views/frame/browser_view.cc

Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 2d7a8e089ccc313d358f640e460bb87708fca26b..326c93ebb118f98145cc45fac08ef3b85f66897f 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -1288,10 +1288,14 @@ void BrowserView::ShowBookmarkBubble(const GURL& url, bool already_bookmarked) {
   scoped_ptr<BubbleSyncPromoDelegate> delegate;
   delegate.reset(new BookmarkBubbleSignInDelegate(browser_.get()));
 
-  BookmarkBubbleView::ShowBubble(GetToolbarView()->GetBookmarkBubbleAnchor(),
+  views::WidgetObserverView* anchor_view =
+      GetToolbarView()->GetBookmarkBubbleAnchor();
+  BookmarkBubbleView::ShowBubble(anchor_view,
                                  gfx::Rect(), nullptr, bookmark_bar_view_.get(),
                                  std::move(delegate), browser_->profile(), url,
                                  already_bookmarked);
+  anchor_view->ObserveWidget(
+      BookmarkBubbleView::bookmark_bubble()->GetWidget());

[sadrul, 2016/01/28 17:45:06]

I would do this differently:

. BubbleIconView becomes a WidgetObserver, and
BubbleIconView::ObserveBubble(Widget*) is added to notify it when there's a
bubble anchored to it.

. BrowserView notifies the ToolbarView when a bubble is created, e.g.:

    views::View* anchor = GetToolbarView()->GetBookmarkBubbleAnchor();
    BookmarkBubbleView::ShowBubble(anchor, ....);
    // Can ShowBubble() return the Widget instead?
    views::Widget* bubble = BookmarkBubbleView::bookmark_bubble()->GetWidget();
    GetToolbarView()->OnBubbleCreatedForAnchor(anchor, widget);


. ToolbarView::OnBubbleCreatedForAnchor(views::View* anchor, views::Widget*
bubble) looks like this:

  bool anchor_is_bubble_icon_view =
      anchor == location_bar()->star_view() ||
      anchor == location_bar()->translate_icon_view() ||
      anchor == location_bar()->save_credit_card_icon_view();
  if (anchor_is_bubble_icon_view)
    static_cast<BubbleIconView*>(anchor)->ObserveBubble(bubble);

This should take care of the issues, right?

[varkha, 2016/01/28 20:09:19]

Yes, this is precisely what I was looking for. Thanks for the idea! Done.

 }
 
 void BrowserView::ShowBookmarkAppBubble(
@@ -1304,9 +1308,12 @@ autofill::SaveCardBubbleView* BrowserView::ShowSaveCreditCardBubble(
     content::WebContents* web_contents,
     autofill::SaveCardBubbleController* controller,
     bool is_user_gesture) {
+  views::WidgetObserverView* anchor_view =
+      GetToolbarView()->GetSaveCreditCardBubbleAnchor();
   autofill::SaveCardBubbleViews* view = new autofill::SaveCardBubbleViews(
-      GetToolbarView()->GetSaveCreditCardBubbleAnchor(), web_contents,
+      anchor_view, web_contents,
       controller);
+  anchor_view->ObserveWidget(view->GetWidget());
   view->Show(is_user_gesture ? autofill::SaveCardBubbleViews::USER_GESTURE
                              : autofill::SaveCardBubbleViews::AUTOMATIC);
   return view;
@@ -1333,10 +1340,14 @@ void BrowserView::ShowTranslateBubble(
   if (IsMinimized())
     return;
 
+  views::WidgetObserverView* anchor_view =
+      GetToolbarView()->GetTranslateBubbleAnchor();
   TranslateBubbleView::ShowBubble(
-      GetToolbarView()->GetTranslateBubbleAnchor(), web_contents, step,
+      anchor_view, web_contents, step,
       error_type, is_user_gesture ? TranslateBubbleView::USER_GESTURE
                                   : TranslateBubbleView::AUTOMATIC);
+  anchor_view->ObserveWidget(
+      TranslateBubbleView::GetCurrentBubble()->GetWidget());
 }
 
 #if defined(ENABLE_ONE_CLICK_SIGNIN)