chrome/browser/ui/views/toolbar/toolbar_view.h - Issue 1518543002: Adds MD ink ripple animations to buttons within location bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_view.h

Issue 1518543002: Adds MD ink ripple animations to buttons within location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds MD ink ripple animations to buttons within location bar (reverted a bad change) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/browser_view.cc ('K') | « chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_view.cc » ('j') | ui/views/controls/button/button.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/toolbar_view.h

diff --git a/chrome/browser/ui/views/toolbar/toolbar_view.h b/chrome/browser/ui/views/toolbar/toolbar_view.h

index c8914bd29fbd3043b76298c0f38a3a0a481fe085..9a055ea4a42f15c4bc6faa6bad3ef5235f145857 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_view.h

+++ b/chrome/browser/ui/views/toolbar/toolbar_view.h

@@ -18,6 +18,7 @@

#include "ui/views/controls/button/menu_button.h"

#include "ui/views/controls/button/menu_button_listener.h"

#include "ui/views/view.h"

+#include "ui/views/widget/widget_observer_view.h"

class AppMenuButton;

class BackButton;

@@ -73,13 +74,13 @@ class ToolbarView : public views::AccessiblePaneView,

virtual bool GetAcceleratorInfo(int id, ui::Accelerator* accel);

// Returns the view to which the bookmark bubble should be anchored.

- views::View* GetBookmarkBubbleAnchor();

+ views::WidgetObserverView* GetBookmarkBubbleAnchor();

// Returns the view to which the "Save credit card" bubble should be anchored.

- views::View* GetSaveCreditCardBubbleAnchor();

+ views::WidgetObserverView* GetSaveCreditCardBubbleAnchor();

// Returns the view to which the Translate bubble should be anchored.

- views::View* GetTranslateBubbleAnchor();

+ views::WidgetObserverView* GetTranslateBubbleAnchor();

// Executes |command| registered by |extension|.

void ExecuteExtensionCommand(const extensions::Extension* extension,