ui/views/bubble/bubble_delegate.cc - Issue 1518543002: Adds MD ink ripple animations to buttons within location bar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_delegate.cc

Issue 1518543002: Adds MD ink ripple animations to buttons within location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adds MD ink ripple animations to buttons within location bar (fixed test build) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc ('K') | « chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc ('k') | ui/views/view.h » ('j') | ui/views/view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/bubble/bubble_delegate.cc

diff --git a/ui/views/bubble/bubble_delegate.cc b/ui/views/bubble/bubble_delegate.cc

index fd922e4454789415611675a7d815c0b526a4b727..97bb8cb931a29f9816331552c97ea5b5beb758fb 100644

--- a/ui/views/bubble/bubble_delegate.cc

+++ b/ui/views/bubble/bubble_delegate.cc

@@ -145,6 +145,9 @@ void BubbleDelegateView::OnWidgetClosing(Widget* widget) {

GetBubbleFrameView()->close_button_clicked()) {

close_reason_ = CloseReason::CLOSE_BUTTON;

}

+ View* anchor_view = GetAnchorView();

+ if (anchor_view)

+ anchor_view->OnBubbleClosing();

}

void BubbleDelegateView::OnWidgetDestroying(Widget* widget) {