Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3343)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc

Issue 1518543002: Adds MD ink ripple animations to buttons within location bar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds MD ink ripple animations to buttons within location bar (fixed test build) Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc b/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc
index 6c360a491f94e387b80faafe3c08c1e5f2b4f077..52948d675de587cd9eca1c2cdf94fff61a10935a 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc
@@ -43,6 +43,10 @@ class ManagePasswordsIconViewTest : public ManagePasswordsTest {
return tooltip;
}
+ const gfx::ImageSkia& GetImage() {
Peter Kasting 2016/01/26 16:59:35 Why bother factoring this out?
varkha 2016/01/26 17:45:45 BubbleIconView::GetImage() is protected and this s
+ return GetView()->GetImage();
+ }
+
private:
DISALLOW_COPY_AND_ASSIGN(ManagePasswordsIconViewTest);
};
@@ -58,7 +62,7 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsIconViewTest, PendingState) {
EXPECT_TRUE(GetView()->visible());
// No tooltip because the bubble is showing.
EXPECT_EQ(base::string16(), GetTooltipText());
- const gfx::ImageSkia active_image = GetView()->GetImage();
+ const gfx::ImageSkia active_image = GetImage();
}
IN_PROC_BROWSER_TEST_F(ManagePasswordsIconViewTest, ManageState) {

Powered by Google App Engine
This is Rietveld 408576698