Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1518463002: Hides ink ripple when a button drag is started (Closed)

Created:
5 years ago by varkha
Modified:
4 years, 11 months ago
Reviewers:
bruthig
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hides ink ripple when a button drag is started Introduces additional callback for Views that tracks when a drag starts. BUG=564941

Patch Set 1 #

Total comments: 2

Patch Set 2 : Hides ink ripple when a button drag is started (-logs) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M ui/views/controls/button/custom_button.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/button/custom_button.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/view.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/view.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
varkha
bruthig@, can you please take a first look?
5 years ago (2015-12-09 16:09:55 UTC) #2
bruthig
lgtm https://codereview.chromium.org/1518463002/diff/1/ui/views/view.cc File ui/views/view.cc (right): https://codereview.chromium.org/1518463002/diff/1/ui/views/view.cc#newcode2199 ui/views/view.cc:2199: LOG(ERROR) << __FUNCTION__ << " calling DoDrag"; Don't ...
5 years ago (2015-12-09 17:35:06 UTC) #3
varkha
https://codereview.chromium.org/1518463002/diff/1/ui/views/view.cc File ui/views/view.cc (right): https://codereview.chromium.org/1518463002/diff/1/ui/views/view.cc#newcode2199 ui/views/view.cc:2199: LOG(ERROR) << __FUNCTION__ << " calling DoDrag"; On 2015/12/09 ...
5 years ago (2015-12-09 17:42:53 UTC) #4
varkha
sadrul@, can you please take a look? Thanks!
5 years ago (2015-12-09 17:43:27 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518463002/20001
5 years ago (2015-12-09 17:45:55 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/147072)
5 years ago (2015-12-09 19:37:42 UTC) #10
varkha
5 years ago (2015-12-11 02:11:50 UTC) #12 
This should be also fixed by https://codereview.chromium.org/1517003002/ which I
think is less intrusive and so better. I will close this if / when that other CL
lands.

Powered by Google App Engine
This is Rietveld 408576698