Hides ink ripple when a button drag is started

ui/views/view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _USE_MATH_DEFINES // For VC++ to get M_PI. This has to be first.
 
 #include "ui/views/view.h"
 
 #include <algorithm>
 #include <cmath>
@@ skipping 1267 matching lines @@
   return ui::DragDropTypes::DRAG_NONE;
 }
 
 void View::OnDragExited() {
 }
 
 int View::OnPerformDrop(const ui::DropTargetEvent& event) {
   return ui::DragDropTypes::DRAG_NONE;
 }
 
+void View::OnDragStarted(const ui::LocatedEvent& event) {
+}
+
 void View::OnDragDone() {
 }
 
 // static
 bool View::ExceededDragThreshold(const gfx::Vector2d& delta) {
   return (abs(delta.x()) > GetHorizontalDragThreshold() ||
           abs(delta.y()) > GetVerticalDragThreshold());
 }
 
 // Accessibility----------------------------------------------------------------
@@ skipping 888 matching lines @@
 bool View::ProcessMouseDragged(const ui::MouseEvent& event) {
   // Copy the field, that way if we're deleted after drag and drop no harm is
   // done.
   ContextMenuController* context_menu_controller = context_menu_controller_;
   const bool possible_drag = GetDragInfo()->possible_drag;
   if (possible_drag &&
       ExceededDragThreshold(GetDragInfo()->start_pt - event.location()) &&
       (!drag_controller_ ||
        drag_controller_->CanStartDragForView(
            this, GetDragInfo()->start_pt, event.location()))) {
+    LOG(ERROR) << __FUNCTION__ << " calling DoDrag";

[bruthig, 2015/12/09 17:35:06]

Don't forget to remove these log statements.

[varkha, 2015/12/09 17:42:53]

Done.

     DoDrag(event, GetDragInfo()->start_pt,
            ui::DragDropTypes::DRAG_EVENT_SOURCE_MOUSE);
   } else {
+    LOG(ERROR) << __FUNCTION__ << " calling OnMouseDragged";
     if (OnMouseDragged(event))
       return true;
     // Fall through to return value based on context menu controller.
   }
   // WARNING: we may have been deleted.
   return (context_menu_controller != NULL) || possible_drag;
 }
 
 void View::ProcessMouseReleased(const ui::MouseEvent& event) {
   if (!kContextMenuOnMousePress && context_menu_controller_ &&
@@ skipping 164 matching lines @@
   Widget* widget = GetWidget();
   // We should only start a drag from an event, implying we have a widget.
   DCHECK(widget);
 
   // Don't attempt to start a drag while in the process of dragging. This is
   // especially important on X where we can get multiple mouse move events when
   // we start the drag.
   if (widget->dragged_view())
     return false;
 
+  OnDragStarted(event);
+
   OSExchangeData data;
   WriteDragData(press_pt, &data);
 
   // Message the RootView to do the drag and drop. That way if we're removed
   // the RootView can detect it and avoid calling us back.
   gfx::Point widget_location(event.location());
   ConvertPointToWidget(this, &widget_location);
   widget->RunShellDrag(this, data, widget_location, drag_operations, source);
   // WARNING: we may have been deleted.
   return true;
 }
 
 }  // namespace views