Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1518393003: Fix valgrind suppressions for libjpeg-turbo warning (Closed)

Created:
5 years ago by msarett
Modified:
5 years ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix valgrind suppressions for libjpeg-turbo warning BUG=skia: Committed: https://skia.googlesource.com/skia/+/a35434aadce3591241d0626529c9978ee567acd9

Patch Set 1 #

Patch Set 2 : Verified locally #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M tools/valgrind.supp View 1 1 chunk +0 lines, -33 lines 0 comments Download

Depends on Patchset:

Issue 1188223002 Patch 60001

Messages

Total messages: 9 (4 generated)
msarett
I wanted the suppressions to be very specific on purpose, to avoid unintentionally hiding other ...
5 years ago (2015-12-14 21:30:32 UTC) #3
msarett
Works locally and is also expected to work on the bot.
5 years ago (2015-12-14 21:57:21 UTC) #4
joshualitt
On 2015/12/14 21:57:21, msarett wrote: > Works locally and is also expected to work on ...
5 years ago (2015-12-14 21:58:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1518393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1518393003/20001
5 years ago (2015-12-14 21:59:22 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-14 22:14:12 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a35434aadce3591241d0626529c9978ee567acd9

Powered by Google App Engine
This is Rietveld 408576698