Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1442)

Unified Diff: Source/core/rendering/svg/SVGRootInlineBox.h

Issue 15183002: Clear SVGInlineTextBox fragments when the text changes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Revised per reviewer comments. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/svg/SVGRootInlineBox.h
diff --git a/Source/core/rendering/svg/SVGRootInlineBox.h b/Source/core/rendering/svg/SVGRootInlineBox.h
index 068033a0a8a97e0914224d733101af64ac927463..b45e98246437921b9722d53e8ce2ff29d843f22e 100644
--- a/Source/core/rendering/svg/SVGRootInlineBox.h
+++ b/Source/core/rendering/svg/SVGRootInlineBox.h
@@ -40,17 +40,17 @@ public:
{
}
- virtual bool isSVGRootInlineBox() const { return true; }
+ virtual bool isSVGRootInlineBox() const OVERRIDE FINAL { return true; }
- virtual float virtualLogicalHeight() const { return m_logicalHeight; }
+ virtual float virtualLogicalHeight() const OVERRIDE FINAL { return m_logicalHeight; }
void setLogicalHeight(float height) { m_logicalHeight = height; }
- virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom);
+ virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom) OVERRIDE FINAL;
void computePerCharacterLayoutInformation();
- virtual FloatRect objectBoundingBox() const { return FloatRect(); }
- virtual FloatRect repaintRectInLocalCoordinates() const { return FloatRect(); }
+ FloatRect objectBoundingBox() const { return FloatRect(); }
eseidel 2013/05/15 18:35:01 Why are these implemented if not virtual?
Stephen Chennney 2013/05/15 19:16:46 Looks like they are not used at all. I'll delete t
+ FloatRect repaintRectInLocalCoordinates() const { return FloatRect(); }
InlineBox* closestLeafChildForPosition(const LayoutPoint&);

Powered by Google App Engine
This is Rietveld 408576698