Cleanup DownloadItemImpl unittests.

Cleanup DownloadItemImpl unittests.

Move test DownloadObserver out of test fixture and rename a few methods.

R=svaldez@chromium.org
BUG=7648
Committed: https://crrev.com/b9f748afd86a5111c4ab4765176e15f5ff9030bc
Cr-Commit-Position: refs/heads/master@{#364898}

[svaldez, 2015-12-11 21:02:21]

lgtm

https://codereview.chromium.org/1518093002/diff/1/content/browser/download/do...
File content/browser/download/download_item_impl_unittest.cc (right):

https://codereview.chromium.org/1518093002/diff/1/content/browser/download/do...
content/browser/download/download_item_impl_unittest.cc:149: bool CheckRemoved()
const { return removed_; }
Possibly change to removed()?

https://codereview.chromium.org/1518093002/diff/1/content/browser/download/do...
content/browser/download/download_item_impl_unittest.cc:151: bool
CheckDestroyed() const { return destroyed_; }
destroyed()?

https://codereview.chromium.org/1518093002/diff/1/content/browser/download/do...
content/browser/download/download_item_impl_unittest.cc:159: int
GetInterruptCount() const { return interrupt_count_; }
Possibly change to interrupt_count().

https://codereview.chromium.org/1518093002/diff/1/content/browser/download/do...
content/browser/download/download_item_impl_unittest.cc:161: int
GetResumeCount() const { return resume_count_; }
Possibly change to resume_count().

[svaldez, 2015-12-11 21:02:22]

lgtm

[asanka, 2015-12-11 21:30:21]

Thanks!

https://codereview.chromium.org/1518093002/diff/1/content/browser/download/do...
File content/browser/download/download_item_impl_unittest.cc (right):

https://codereview.chromium.org/1518093002/diff/1/content/browser/download/do...
content/browser/download/download_item_impl_unittest.cc:149: bool CheckRemoved()
const { return removed_; }
On 2015/12/11 21:02:21, svaldez wrote:
> Possibly change to removed()?

Changed to download_removed() since otherwise the calls sites look like
"observer.removed()" which seemed a bit confusing.

https://codereview.chromium.org/1518093002/diff/1/content/browser/download/do...
content/browser/download/download_item_impl_unittest.cc:151: bool
CheckDestroyed() const { return destroyed_; }
On 2015/12/11 21:02:21, svaldez wrote:
> destroyed()?

Went with download_destroyed() for same reason.

https://codereview.chromium.org/1518093002/diff/1/content/browser/download/do...
content/browser/download/download_item_impl_unittest.cc:159: int
GetInterruptCount() const { return interrupt_count_; }
On 2015/12/11 21:02:21, svaldez wrote:
> Possibly change to interrupt_count().

Done.

https://codereview.chromium.org/1518093002/diff/1/content/browser/download/do...
content/browser/download/download_item_impl_unittest.cc:161: int
GetResumeCount() const { return resume_count_; }
On 2015/12/11 21:02:21, svaldez wrote:
> Possibly change to resume_count().

Done.

[asanka, 2015-12-12 03:44:44]

The CQ bit was checked by asanka@chromium.org

[asanka, 2015-12-12 03:44:45]

The patchset sent to the CQ was uploaded after l-g-t-m from svaldez@chromium.org
Link to the patchset: https://codereview.chromium.org/1518093002/#ps60001
(title: "Catch up with upstream")

[commit-bot: I haz the power, 2015-12-12 03:45:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1518093002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1518093002/60001

[commit-bot: I haz the power, 2015-12-12 04:14:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-12 04:15:21]

Description was changed from

==========
Cleanup DownloadItemImpl unittests.

Move test DownloadObserver out of test fixture and rename a few methods.

R=svaldez@chromium.org
BUG=7648
==========

to

==========
Cleanup DownloadItemImpl unittests.

Move test DownloadObserver out of test fixture and rename a few methods.

R=svaldez@chromium.org
BUG=7648

Committed: https://crrev.com/b9f748afd86a5111c4ab4765176e15f5ff9030bc
Cr-Commit-Position: refs/heads/master@{#364898}
==========

[commit-bot: I haz the power, 2015-12-12 04:15:22]

Patchset 4 (id:??) landed as
https://crrev.com/b9f748afd86a5111c4ab4765176e15f5ff9030bc
Cr-Commit-Position: refs/heads/master@{#364898}