Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1517283002: Use a test BrowserContext in DownloadItemImpl unittests. (Closed)

Created:
5 years ago by asanka
Modified:
5 years ago
Reviewers:
svaldez
CC:
chromium-reviews, asanka, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a test BrowserContext in DownloadItemImpl unittests. R=svaldez@chromium.org BUG=7648 Committed: https://crrev.com/54d57f1df4947ecf47f44aa3b860c3f77d97b2fa Cr-Commit-Position: refs/heads/master@{#364880}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Clarify what we are testing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M content/browser/download/download_item_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 1 7 chunks +17 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
asanka
5 years ago (2015-12-11 20:00:07 UTC) #4
svaldez
lgtm https://codereview.chromium.org/1517283002/diff/1/content/browser/download/download_item_impl_unittest.cc File content/browser/download/download_item_impl_unittest.cc (right): https://codereview.chromium.org/1517283002/diff/1/content/browser/download/download_item_impl_unittest.cc#newcode435 content/browser/download/download_item_impl_unittest.cc:435: // the download is interrupted. But the mock ...
5 years ago (2015-12-11 20:53:04 UTC) #5
asanka
Thanks! https://codereview.chromium.org/1517283002/diff/1/content/browser/download/download_item_impl_unittest.cc File content/browser/download/download_item_impl_unittest.cc (right): https://codereview.chromium.org/1517283002/diff/1/content/browser/download/download_item_impl_unittest.cc#newcode435 content/browser/download/download_item_impl_unittest.cc:435: // the download is interrupted. But the mock ...
5 years ago (2015-12-11 21:23:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517283002/20001
5 years ago (2015-12-11 21:25:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/144076)
5 years ago (2015-12-11 23:01:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517283002/20001
5 years ago (2015-12-12 02:29:51 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-12 03:40:40 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-12 03:41:35 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54d57f1df4947ecf47f44aa3b860c3f77d97b2fa
Cr-Commit-Position: refs/heads/master@{#364880}

Powered by Google App Engine
This is Rietveld 408576698