Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1518063002: Fix FNL Werror=maybe-unitialized and skia API changes in FNL build (Closed)

Created:
5 years ago by jamesr
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, cdotut_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix FNL Werror=maybe-unitialized and skia API changes in FNL build Also moves ozone_demo out of the default build target but leaves it as a named group so it can be built if needed. Its build is wonky right now. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2b16328c26804b30c75c5796cebc4f2d71489055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M BUILD.gn View 2 chunks +9 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/array_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jamesr
With this I can build the default target for fnl in release mode
5 years ago (2015-12-11 18:44:50 UTC) #2
kulakowski
lgtm
5 years ago (2015-12-11 18:46:07 UTC) #4
jamesr
ozone_unittests doesn't link in debug. I'll put that in the off-by-default target too after checking ...
5 years ago (2015-12-11 19:02:56 UTC) #5
jamesr
OK, that's the only one. Will put it in the same group and rename it ...
5 years ago (2015-12-11 19:07:13 UTC) #6
jamesr
5 years ago (2015-12-11 19:07:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b16328c26804b30c75c5796cebc4f2d71489055 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698