Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: mojo/public/cpp/bindings/tests/array_unittest.cc

Issue 1518063002: Fix FNL Werror=maybe-unitialized and skia API changes in FNL build (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | ui/ozone/platform/drm/gpu/drm_surface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/tests/array_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/array_unittest.cc b/mojo/public/cpp/bindings/tests/array_unittest.cc
index c61113cd82f530613cd6489cd3a74b609cd2d5b4..38917809ecb45db3c9faa7b28975bdd12d242436 100644
--- a/mojo/public/cpp/bindings/tests/array_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/array_unittest.cc
@@ -454,7 +454,7 @@ TEST_F(ArrayTest, Serialization_StructWithArrayOfInterfacePtr) {
size);
FixedBufferForTesting buf(size * 2);
- StructWithInterfaceArray::Data_* struct_arr_iface_data;
+ StructWithInterfaceArray::Data_* struct_arr_iface_data = nullptr;
// 1. This should fail because |structs_array| has an invalid InterfacePtr<>
// and it is not nullable.
EXPECT_EQ(mojo::internal::ValidationError::UNEXPECTED_NULL_POINTER,
@@ -764,7 +764,7 @@ TEST_F(ArrayTest, Serialization_ArrayOfStructPtr) {
2 * 8U + // array payload (2 pointers)
8U + 4 * 4U, // struct header + contents (4 int32)
size_with_null);
- Array_Data<Rect::Data_*>* output_with_null;
+ Array_Data<Rect::Data_*>* output_with_null = nullptr;
// 1. Array with non-nullable structs should fail serialization due to
// the null first element.
@@ -808,7 +808,7 @@ TEST_F(ArrayTest, Serialization_ArrayOfStructPtr) {
size_without_null);
FixedBufferForTesting buf_without_null(size_without_null);
- Array_Data<Rect::Data_*>* output_without_null;
+ Array_Data<Rect::Data_*>* output_without_null = nullptr;
EXPECT_EQ(mojo::internal::ValidationError::NONE,
SerializeArray_(&array, &buf_without_null, &output_without_null,
&validate_non_nullable));
« no previous file with comments | « BUILD.gn ('k') | ui/ozone/platform/drm/gpu/drm_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698