Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: src/core/SkOrderedReadBuffer.cpp

Issue 15179008: Add buffer helper to read directly into SkString to avoid extra copying (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: rebasing Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkOrderedReadBuffer.h ('k') | src/core/SkPaintOptionsAndroid.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkOrderedReadBuffer.cpp
diff --git a/src/core/SkOrderedReadBuffer.cpp b/src/core/SkOrderedReadBuffer.cpp
index 4af64706a1db70e9246863a75f1ef9d183982c11..560b5b68648b87c2ed35e5bd71af8e5279250f72 100644
--- a/src/core/SkOrderedReadBuffer.cpp
+++ b/src/core/SkOrderedReadBuffer.cpp
@@ -88,12 +88,10 @@ int32_t SkOrderedReadBuffer::read32() {
return fReader.readInt();
}
-char* SkOrderedReadBuffer::readString() {
- const char* string = fReader.readString();
- const size_t length = strlen(string);
- char* value = (char*)sk_malloc_throw(length + 1);
- strcpy(value, string);
- return value;
+void SkOrderedReadBuffer::readString(SkString* string) {
+ size_t len;
+ const char* strContents = fReader.readString(&len);
+ string->set(strContents, len);
}
void* SkOrderedReadBuffer::readEncodedString(size_t* length, SkPaint::TextEncoding encoding) {
« no previous file with comments | « src/core/SkOrderedReadBuffer.h ('k') | src/core/SkPaintOptionsAndroid.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698