src/core/SkOrderedReadBuffer.h - Issue 15179008: Add buffer helper to read directly into SkString to avoid extra copying

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkOrderedReadBuffer.h

Issue 15179008: Add buffer helper to read directly into SkString to avoid extra copying (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: rebasing Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkOrderedReadBuffer.h

diff --git a/src/core/SkOrderedReadBuffer.h b/src/core/SkOrderedReadBuffer.h

index c609ec8be267d8304e232d050f3872671e7f7ac8..3ec76d91c42866f5dd31771ced72a2a4080e95cb 100644

--- a/src/core/SkOrderedReadBuffer.h

+++ b/src/core/SkOrderedReadBuffer.h

@@ -44,7 +44,7 @@ public:

virtual int32_t read32() SK_OVERRIDE;

// strings -- the caller is responsible for freeing the string contents

- virtual char* readString() SK_OVERRIDE;

+ virtual void readString(SkString* string) SK_OVERRIDE;

virtual void* readEncodedString(size_t* length, SkPaint::TextEncoding encoding) SK_OVERRIDE;

// common data structures

« no previous file with comments | « include/core/SkPaintOptionsAndroid.h ('k') | src/core/SkOrderedReadBuffer.cpp » ('j') | no next file with comments »