Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1517753003: [proxies] Fix JSObject::AllCanRead for Proxies on the prototype chain (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Fix JSObject::AllCanRead for Proxies on the prototype chain Committed: https://crrev.com/cf463174832fca1d65ab1ecc105419b24549508b Cr-Commit-Position: refs/heads/master@{#32805}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/objects.cc View 1 chunk +3 lines, -0 lines 1 comment Download
A test/mjsunit/harmony/proxies-accesschecks.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
PTAL. This fixes a # Fatal error in ../src/lookup.cc, line 49 # Check failed: JSPROXY ...
5 years ago (2015-12-11 14:52:28 UTC) #2
Toon Verwaest
lgtm
5 years ago (2015-12-11 15:12:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517753003/1
5 years ago (2015-12-11 15:12:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 15:51:42 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-11 15:51:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf463174832fca1d65ab1ecc105419b24549508b
Cr-Commit-Position: refs/heads/master@{#32805}

Powered by Google App Engine
This is Rietveld 408576698