Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: src/objects.cc

Issue 1517753003: [proxies] Fix JSObject::AllCanRead for Proxies on the prototype chain (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/harmony/proxies-accesschecks.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index bfb58b87919869702f9736c6c95285bccb08cc79..6b951203a02e52ecbd3cc5a0e05bcfabfcb3bd85 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -1188,6 +1188,9 @@ bool JSObject::AllCanRead(LookupIterator* it) {
}
} else if (it->state() == LookupIterator::INTERCEPTOR) {
if (it->GetInterceptor()->all_can_read()) return true;
+ } else if (it->state() == LookupIterator::JSPROXY) {
+ // Stop lookupiterating. And no, AllCanNotRead.
Jakob Kummerow 2015/12/11 14:52:28 Do you like this comment, or is it too friday?
+ return false;
}
}
return false;
« no previous file with comments | « no previous file | test/mjsunit/harmony/proxies-accesschecks.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698