Issue 1517693005: Add check for DEBUG to functions disabled on 386

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1517693005: Add check for DEBUG to functions disabled on 386 (Closed)

Created:
5 years ago by fbarchard1

Modified:
5 years ago

Reviewers:
harryjin

Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master

Target Ref:
refs/heads/master

Project:
libyuv

Visibility:
Public.

Add check for DEBUG to functions disabled on 386 Some functions run out of registers when compiled for debug, fpic, with stack frames on 32 bit x86 with clang. Previously they were enabled based on _DEBUG but that macro is not set in some build systems. This CL adds DEBUG macro as well to cover those environments. R=harryjin@google.com BUG=libyuv:532 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/44373d8fbb25692e29883cda2f9c6d40e5a9da3b

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
M	README.chromium	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/libyuv/row.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	include/libyuv/version.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

fbarchard1

5 years ago (2015-12-10 23:42:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
44373d8fbb25692e29883cda2f9c6d40e5a9da3b (presubmit successful).