Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: include/libyuv/row.h

Issue 1517693005: Add check for DEBUG to functions disabled on 386 (Closed) Base URL: https://chromium.googlesource.com/libyuv/libyuv@master
Patch Set: allow clangcl to build using row_win.cc Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « README.chromium ('k') | include/libyuv/version.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/libyuv/row.h
diff --git a/include/libyuv/row.h b/include/libyuv/row.h
index cf96c0516aa675c26f1f9096fc1395370d23faa4..31de3e089cbfb62d404d05392b83e1a459c08ab3 100644
--- a/include/libyuv/row.h
+++ b/include/libyuv/row.h
@@ -105,12 +105,12 @@ extern "C" {
#define HAS_COPYROW_SSE2
#define HAS_H422TOARGBROW_SSSE3
#define HAS_I400TOARGBROW_SSE2
-#if !defined(__i386__)
+// The following functions fail on gcc/clang 32 bit.
+// caveat: clangcl uses row_win.cc which works.
+#if !defined(__i386__) || !defined(DEBUG) || defined(_MSC_VER)
// TODO(fbarchard): fix build error on x86 debug
// https://code.google.com/p/libyuv/issues/detail?id=524
#define HAS_I411TOARGBROW_SSSE3
-#endif
-#if !(defined(_DEBUG) && defined(__i386__))
// TODO(fbarchard): fix build error on android_full_debug=1
// https://code.google.com/p/libyuv/issues/detail?id=517
#define HAS_I422ALPHATOARGBROW_SSSE3
« no previous file with comments | « README.chromium ('k') | include/libyuv/version.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698