Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Issue 1517693004: extract LibraryPrefixContributor from imported reference contributor (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

extract LibraryPrefixContributor from imported reference contributor R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7ad6c0f1f90b5deca5087bb4c7c35625bc74c5bd

Patch Set 1 #

Patch Set 2 : include new test in suite #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+486 lines, -65 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 3 chunks +16 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/services/completion/dart/library_prefix_contributor.dart View 1 chunk +55 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart View 4 chunks +3 lines, -30 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 10 chunks +20 lines, -10 lines 0 comments Download
A pkg/analysis_server/test/services/completion/dart/library_prefix_contributor_test.dart View 1 chunk +377 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/test_all.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart View 5 chunks +2 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-10 23:10:22 UTC) #2
scheglov
LGTM
5 years ago (2015-12-10 23:22:05 UTC) #3
danrubel
5 years ago (2015-12-11 03:43:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
7ad6c0f1f90b5deca5087bb4c7c35625bc74c5bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698