pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart - Issue 1517693004: extract LibraryPrefixContributor from imported reference contributor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart

Issue 1517693004: extract LibraryPrefixContributor from imported reference contributor (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart_completion_cache.dart ('k') | pkg/analysis_server/test/domain_completion_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart b/pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart

index b283ce9adae57f6f5c58390807fe9caf1527e666..f2a9cfa55ef5ca48ee83db08a506eb8fb29e1e55 100644

--- a/pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart

@@ -143,7 +143,6 @@ class _ImportedSuggestionBuilder extends ElementSuggestionBuilder

}

DartCompletionCache cache = request.cache;

_addFilteredSuggestions(filterText, cache.importedConstructorSuggestions);

- _addFilteredSuggestions(filterText, cache.libraryPrefixSuggestions);

}

/**

@@ -258,7 +257,6 @@ class _ImportedSuggestionBuilder extends ElementSuggestionBuilder

DartCompletionCache cache = request.cache;

if (optype.includeTypeNameSuggestions) {

_addFilteredSuggestions(filterText, cache.importedTypeSuggestions);

- _addFilteredSuggestions(filterText, cache.libraryPrefixSuggestions);

}

if (optype.includeReturnValueSuggestions) {

_addFilteredSuggestions(filterText, cache.otherImportedSuggestions);