Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 1517463002: [runtime] [proxies] adding tests for uncovered branches (Closed)

Created:
5 years ago by Camillo Bruni
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] [proxies] adding tests for uncovered branches fly-by fix of Proxy [[Construct]] on mips. BUG=v8:1543 LOG=N Committed: https://crrev.com/c20156c5501db7c2f4a51ab5812d66bf76100ef6 Cr-Commit-Position: refs/heads/master@{#32758}

Patch Set 1 #

Patch Set 2 : merge master #

Patch Set 3 : dropping mips changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -11 lines) Patch
M src/objects.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-define-property.js View 1 chunk +10 lines, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-enumerate.js View 1 chunk +6 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/proxies-set-prototype-of.js View 4 chunks +72 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517463002/1
5 years ago (2015-12-09 17:18:38 UTC) #3
Camillo Bruni
PTAL
5 years ago (2015-12-09 17:22:31 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-09 18:02:44 UTC) #7
Toon Verwaest
lgtm
5 years ago (2015-12-10 12:44:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1517463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1517463002/40001
5 years ago (2015-12-10 14:53:28 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-10 15:34:52 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-10 15:35:25 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c20156c5501db7c2f4a51ab5812d66bf76100ef6
Cr-Commit-Position: refs/heads/master@{#32758}

Powered by Google App Engine
This is Rietveld 408576698