Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1516893002: Second reland: Fix incorrect sign in scroll and content box offset in absoluteToLocalPoint. (Closed)

Created:
5 years ago by chrishtr
Modified:
5 years ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Second reland: Fix incorrect sign in scroll and content box offset in absoluteToLocalPoint. Also, refactored the tests a bit to share more code for iframes and reduce boilerplate. (https://codereview.chromium.org/1511183003) Now passes unittests on Android, by making the scrollbars display:none. TBR=wangxianzhu@chromium.org BUG=566238 Committed: https://crrev.com/c77fbd5867bd43264ca59eb40aaebbf7d574d876 Cr-Commit-Position: refs/heads/master@{#364419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -63 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTestHelper.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp View 2 chunks +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 6 chunks +52 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/page/PrintContextTest.cpp View 5 chunks +6 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516893002/1
5 years ago (2015-12-10 17:30:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 19:08:24 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-10 19:10:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c77fbd5867bd43264ca59eb40aaebbf7d574d876
Cr-Commit-Position: refs/heads/master@{#364419}

Powered by Google App Engine
This is Rietveld 408576698