Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1511183003: Reland: Fix incorrect sign in scroll and content box offset in absoluteToLocalPoint. (Closed)

Created:
5 years ago by chrishtr
Modified:
5 years ago
Reviewers:
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Fix incorrect sign in scroll and content box offset in absoluteToLocalPoint. Also, refactored the tests a bit to share more code for iframes and reduce boilerplate. (https://codereview.chromium.org/1504363004) Now compiles with Oilpan. TBR=wangxianzhu@chromium.org BUG=566238 Committed: https://crrev.com/437435aad459dd054b5c0e9a7e5b09ebcac6d902 Cr-Commit-Position: refs/heads/master@{#364198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -63 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTestHelper.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp View 2 chunks +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp View 6 chunks +53 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/page/PrintContextTest.cpp View 5 chunks +6 lines, -38 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511183003/1
5 years ago (2015-12-09 17:37:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/147065)
5 years ago (2015-12-09 19:43:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1511183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1511183003/1
5 years ago (2015-12-09 19:49:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 23:11:55 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/437435aad459dd054b5c0e9a7e5b09ebcac6d902 Cr-Commit-Position: refs/heads/master@{#364198}
5 years ago (2015-12-09 23:13:06 UTC) #13
johnme
5 years ago (2015-12-10 14:24:14 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1510233006/ by johnme@chromium.org.

The reason for reverting is: Caused the following tests to fail reliably on
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N...:

[FAIL] CompositedLayerMappingTest.InterestRectOfIframeWithContentBoxOffset:
[ RUN      ] CompositedLayerMappingTest.InterestRectOfIframeWithContentBoxOffset
[INFO:SkFontMgr_android_parser.cpp(597)] [SkFontMgr Android Parser]
'/system/etc/fonts.xml' could not be opened

[INFO:SkFontMgr_android_parser.cpp(597)] [SkFontMgr Android Parser]
'/vendor/etc/fallback_fonts.xml' could not be opened

../../third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp:579:
Failure
Value of: actualRect.width()
  Actual: 500
Expected: IntRect(0, 0, 485, 7500).width()
Which is: 485
[  FAILED  ] CompositedLayerMappingTest.InterestRectOfIframeWithContentBoxOffset
(43 ms)
[FAIL] CompositedLayerMappingTest.InterestRectOfScrolledIframe:
[ RUN      ] CompositedLayerMappingTest.InterestRectOfScrolledIframe
[INFO:SkFontMgr_android_parser.cpp(597)] [SkFontMgr Android Parser]
'/system/etc/fonts.xml' could not be opened

[INFO:SkFontMgr_android_parser.cpp(597)] [SkFontMgr Android Parser]
'/vendor/etc/fallback_fonts.xml' could not be opened

../../third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp:556:
Failure
Value of: actualRect.width()
  Actual: 500
Expected: IntRect(0, 3500, 485, 4500).width()
Which is: 485
[  FAILED  ] CompositedLayerMappingTest.InterestRectOfScrolledIframe (50 ms).

Powered by Google App Engine
This is Rietveld 408576698