content/renderer/render_widget.h - Issue 1516723003: [Element / Autofill] Add boundsInViewportFloat() to fix <input> popup misalignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_widget.h

Issue 1516723003: [Element / Autofill] Add boundsInViewportFloat() to fix <input> popup misalignment. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refator to use boundsInViewportFloat() eventually, but keep boundsInViewportInt(). Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_widget.h

diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h

index f9b2d4f10b513e56b6004a59199b6572b1194a32..5eaaae5cbce0f1d49769e9317a0712ed7aee16e8 100644

--- a/content/renderer/render_widget.h

+++ b/content/renderer/render_widget.h

@@ -23,6 +23,7 @@

#include "ipc/ipc_listener.h"

#include "ipc/ipc_sender.h"

#include "third_party/WebKit/public/platform/WebDisplayMode.h"

+#include "third_party/WebKit/public/platform/WebFloatRect.h"

#include "third_party/WebKit/public/platform/WebRect.h"

#include "third_party/WebKit/public/web/WebCompositionUnderline.h"

#include "third_party/WebKit/public/web/WebInputEvent.h"

@@ -200,6 +201,7 @@ class CONTENT_EXPORT RenderWidget

// Converts the |rect| from Viewport coordinates to Window coordinates.

// See RenderView::convertViewportToWindow for more details.

void convertViewportToWindow(blink::WebRect* rect);

+ void convertViewportToWindow(blink::WebFloatRect* rect);

#if defined(OS_ANDROID)

// Notifies that a tap was not consumed, so showing a UI for the unhandled

« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »