Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: content/renderer/render_view_impl.cc

Issue 1516723003: [Element / Autofill] Add boundsInViewportFloat() to fix <input> popup misalignment. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refator to use boundsInViewportFloat() eventually, but keep boundsInViewportInt(). Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index a5aa8179f99dec9406c6b7687fa5e52afd36df4e..ce00cd5b8728441888360fc66b17a40d7277061a 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1931,7 +1931,8 @@ void RenderViewImpl::focusedNodeChanged(const WebNode& fromNode,
bool is_editable = false;
if (!toNode.isNull() && toNode.isElementNode()) {
WebElement element = const_cast<WebNode&>(toNode).to<WebElement>();
- blink::WebRect rect = element.boundsInViewport();
+ // TODO(huangs): Use getElementBoundingBoxWindow().
+ blink::WebRect rect = element.boundsInViewportInt();
convertViewportToWindow(&rect);
node_bounds = gfx::Rect(rect);
is_editable = element.isEditable();
@@ -2132,6 +2133,16 @@ void RenderViewImpl::convertViewportToWindow(blink::WebRect* rect) {
RenderWidget::convertViewportToWindow(rect);
}
+void RenderViewImpl::convertViewportToWindow(blink::WebFloatRect* rect) {
+ RenderWidget::convertViewportToWindow(rect);
+}
+
+void RenderViewImpl::getElementBoundingBoxWindow(
+ blink::WebElement* element, blink::WebFloatRect* rect) {
+ *rect = element->boundsInViewportFloat();
+ convertViewportToWindow(rect);
+}
+
void RenderViewImpl::didChangeIcon(WebLocalFrame* frame,
WebIconURL::Type icon_type) {
if (frame->parent())
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/renderer/render_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698