Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1516723002: Test for consistent errors for optimized forms of '-'. (Closed)

Created:
5 years ago by sra1
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test for consistent errors for optimized forms of '-'. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/dfc9ad26300c81d6f9505768b0f36ca90d5601a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -0 lines) Patch
A tests/compiler/dart2js_extra/consistent_subtract_error_test.dart View 1 chunk +113 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
This follows the same pattern as the 'add' version.
5 years ago (2015-12-09 23:32:54 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years ago (2015-12-10 01:22:39 UTC) #3
sra1
5 years ago (2015-12-10 19:32:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dfc9ad26300c81d6f9505768b0f36ca90d5601a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698