Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: tests/compiler/dart2js_extra/consistent_subtract_error_test.dart

Issue 1516723002: Test for consistent errors for optimized forms of '-'. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js_extra/consistent_subtract_error_test.dart
diff --git a/tests/compiler/dart2js_extra/consistent_subtract_error_test.dart b/tests/compiler/dart2js_extra/consistent_subtract_error_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..757c37dff58a3d4044d61ce406157a2e8add75e0
--- /dev/null
+++ b/tests/compiler/dart2js_extra/consistent_subtract_error_test.dart
@@ -0,0 +1,113 @@
+// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import "package:expect/expect.dart";
+
+// Test that optimized '-' and slow path '-' produce the same error.
+
+@NoInline()
+@AssumeDynamic()
+confuse(x) => x;
+
+void check2(String name, name1, f1, name2, f2) {
+ Error trap(part, f) {
+ try {
+ f();
+ } catch (e) {
+ return e;
+ }
+ Expect.fail('should throw: $name.$part');
+ }
+ var e1 = trap(name1, f1);
+ var e2 = trap(name2, f2);
+ var s1 = '$e1';
+ var s2 = '$e2';
+ Expect.equals(s1, s2, '\n $name.$name1: "$s1"\n $name.$name2: "$s2"\n');
+}
+
+void check(String name, f1, f2, [f3, f4, f5, f6, f7]) {
+ check2(name, 'f1', f1, 'f2', f2);
+ if (f3 != null) check2(name, 'f1', f1, 'f3', f3);
+ if (f4 != null) check2(name, 'f1', f1, 'f4', f4);
+ if (f5 != null) check2(name, 'f1', f1, 'f5', f5);
+ if (f6 != null) check2(name, 'f1', f1, 'f6', f6);
+ if (f7 != null) check2(name, 'f1', f1, 'f7', f7);
+}
+
+class IntMinusNull {
+ static f1() {
+ return confuse(1) - confuse(null);
+ }
+
+ static f2() {
+ return confuse(1) - null;
+ }
+
+ static f3() {
+ return (confuse(1) as int) - confuse(null);
+ }
+
+ static f4() {
+ return (confuse(1) as int) - null;
+ }
+
+ static f5() {
+ var a = confuse(true) ? 1 : 2; // Small int with unknown value.
+ return a - confuse(null);
+ }
+
+ static f6() {
+ var a = confuse(true) ? 1 : 2; // Small int with unknown value.
+ return a - null;
+ }
+
+ static f7() {
+ return 1 - null;
+ }
+
+ static test() {
+ check('IntMinusNull', f1, f2, f3, f4, f5, f6, f7);
+ }
+}
+
+class IntMinusString {
+ static f1() {
+ return confuse(1) - confuse('a');
+ }
+
+ static f2() {
+ return confuse(1) - 'a';
+ }
+
+ static f3() {
+ var a = confuse(true) ? 1 : 2; // Small int with unknown value.
+ return a - confuse('a');
+ }
+
+ static f4() {
+ return (confuse(1) as int) - confuse('a');
+ }
+
+ static f5() {
+ return (confuse(1) as int) - 'a';
+ }
+
+ static f6() {
+ var a = confuse(true) ? 1 : 2; // Small int with unknown value.
+ return a - 'a';
+ }
+
+ static f7() {
+ return 1 - 'a';
+ }
+
+ static test() {
+ check('IntMinusString', f1, f2, f3, f4, f5, f6, f7);
+ }
+}
+
+main() {
+ IntMinusNull.test();
+ IntMinusString.test();
+}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698