Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Unified Diff: third_party/re2/README.chromium

Issue 1516543002: Update re2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update instructions Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/re2/README.chromium
diff --git a/third_party/re2/README.chromium b/third_party/re2/README.chromium
index 3522d4c85da53eefbde24591383208c1e861511a..e93dd1ddb002be42c382f835a1351b863dbafbb8 100644
--- a/third_party/re2/README.chromium
+++ b/third_party/re2/README.chromium
@@ -1,9 +1,8 @@
Name: re2 - an efficient, principled regular expression library
Short Name: re2
URL: https://github.com/google/re2
-Version: 7f91923f3ad4
-Date: 2012-06-20
-Revision: 100:7f91923f3ad4
+Version: dba3349aba83b5588e85e5ecf2b56c97f2d259b7
+Date: 2015-12-10
License: BSD 3-Clause
License File: LICENSE
Security Critical: yes
@@ -12,23 +11,10 @@ Description:
RE2 is a fast, safe, thread-friendly alternative to backtracking regular
expression engines like those used in PCRE, Perl, and Python.
-Local Modifications (to be applied in this order):
-- Remove valgrind specific code that exists in chromium already
- (patches/remove-valgrind-code.patch)
-- Support for Windows (patches/re2-msvc9-chrome.patch)
-- Support Android (patches/re2-android.patch)
-- Remove static initializers (patches/remove-static-initializers.patch)
-- Support libcxx (patches/re2-libcxx.patch)
- https://code.google.com/p/re2/issues/detail?id=76
-- Memory optimization for filtered trees
- (patches/re2-memory-optimization.patch)
-- Prevent unwanted reports from MemorySanitizer. Note: there's an upstream fix
- for this (https://code.google.com/p/re2/issues/detail?id=77) which is rendered
- ineffective by patches/remove-valgrind-code.patch
- (patches/re2-msan.patch)
-- Remove comparisons of this with NULL, merges upstream b92ce81f1e25
-- Let COMPILE_ASSERT use static_assert if available, merges upstream
- 2225f94df8ec
-- Merge upstream cc56ba02d9d2bdafa614ad5ebf564dde287625bb.
-- Suppress more unwanted reports from MemorySanitizer.
- (patches/sparse-array-valgrind.patch)
+To update RE2, execute the following commands from your Chromium checkout:
tfarina 2015/12/14 09:30:04 Thanks for documenting the instructions. Hopefully
+$ git clone https://github.com/google/re2 third_party/re2_new
+$ cp third_party/re2/OWNERS third_party/re2/BUILD.gn third_party/re2/re2.gyp \
+third_party/re2/README.chromium third_party/re2/DEPS third_party/re2_new
+$ rm -rf third_party/re2_new/.git
+$ rm -rf third_party/re2
+$ mv third_party/re2_new third_party/re2
Nico 2015/12/15 19:04:56 Should probably have some note about updating gyp
« no previous file with comments | « third_party/re2/README ('k') | third_party/re2/WORKSPACE » ('j') | third_party/re2/re2.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698