third_party/re2/README.chromium - Issue 1516543002: Update re2

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/re2/README.chromium

Issue 1516543002: Update re2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update instructions Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: re2 - an efficient, principled regular expression library	1 Name: re2 - an efficient, principled regular expression library

2 Short Name: re2	2 Short Name: re2

3 URL: https://github.com/google/re2	3 URL: https://github.com/google/re2

4 Version: 7f91923f3ad4	4 Version: dba3349aba83b5588e85e5ecf2b56c97f2d259b7

5 Date: 2012-06-20	5 Date: 2015-12-10

6 Revision: 100:7f91923f3ad4

7 License: BSD 3-Clause	6 License: BSD 3-Clause

8 License File: LICENSE	7 License File: LICENSE

9 Security Critical: yes	8 Security Critical: yes

10	9

11 Description:	10 Description:

12 RE2 is a fast, safe, thread-friendly alternative to backtracking regular	11 RE2 is a fast, safe, thread-friendly alternative to backtracking regular

13 expression engines like those used in PCRE, Perl, and Python.	12 expression engines like those used in PCRE, Perl, and Python.

14	13

15 Local Modifications (to be applied in this order):	14 To update RE2, execute the following commands from your Chromium checkout:
	tfarina 2015/12/14 09:30:04 Thanks for documenting the instructions. Hopefully Thanks for documenting the instructions. Hopefully we don't have the complication of dealing with patches anymore (at least not for now). And after that we can "force" people to upstream first, instead of patching our "fork".
16 - Remove valgrind specific code that exists in chromium already	15 $ git clone https://github.com/google/re2 third_party/re2_new

17 (patches/remove-valgrind-code.patch)	16 $ cp third_party/re2/OWNERS third_party/re2/BUILD.gn third_party/re2/re2.gyp \

18 - Support for Windows (patches/re2-msvc9-chrome.patch)	17 third_party/re2/README.chromium third_party/re2/DEPS third_party/re2_new

19 - Support Android (patches/re2-android.patch)	18 $ rm -rf third_party/re2_new/.git

20 - Remove static initializers (patches/remove-static-initializers.patch)	19 $ rm -rf third_party/re2

21 - Support libcxx (patches/re2-libcxx.patch)	20 $ mv third_party/re2_new third_party/re2
	Nico 2015/12/15 19:04:56 Should probably have some note about updating gyp Should probably have some note about updating gyp and gn files too
22 https://code.google.com/p/re2/issues/detail?id=76

23 - Memory optimization for filtered trees

24 (patches/re2-memory-optimization.patch)

25 - Prevent unwanted reports from MemorySanitizer. Note: there's an upstream fix

26 for this (https://code.google.com/p/re2/issues/detail?id=77) which is rendered

27 ineffective by patches/remove-valgrind-code.patch

28 (patches/re2-msan.patch)

29 - Remove comparisons of this with NULL, merges upstream b92ce81f1e25

30 - Let COMPILE_ASSERT use static_assert if available, merges upstream

31 2225f94df8ec

32 - Merge upstream cc56ba02d9d2bdafa614ad5ebf564dde287625bb.

33 - Suppress more unwanted reports from MemorySanitizer.

34 (patches/sparse-array-valgrind.patch)

OLD	NEW

« no previous file with comments | « third_party/re2/README ('k') | third_party/re2/WORKSPACE » ('j') | third_party/re2/re2.gyp » ('J')