Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1516483004: GN: error out if attempting to use_sysroot with gcc (Closed)

Created:
5 years ago by Sam Clegg
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@arm_gn
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: error out if attempting to use_sysroot with gcc Currently out sysroots are not gcc compatible (except for gcc 4.6 which isn't capable of building chromium). BUG=567206 Committed: https://crrev.com/3e86f046bdf3df1b37189a7204095ddfa837963f Cr-Commit-Position: refs/heads/master@{#364131}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/config/sysroot.gni View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Sam Clegg
5 years ago (2015-12-09 17:37:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516483004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516483004/20001
5 years ago (2015-12-09 17:40:32 UTC) #4
Dirk Pranke
lgtm. make sure you run this through all of the GN trybots, in particular the ...
5 years ago (2015-12-09 17:40:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-09 18:31:54 UTC) #7
Sam Clegg
On 2015/12/09 17:40:53, Dirk Pranke wrote: > lgtm. > > make sure you run this ...
5 years ago (2015-12-09 19:07:34 UTC) #8
Dirk Pranke
I just triggered the ones that (I think) aren't in the CQ by default. That ...
5 years ago (2015-12-09 19:11:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1516483004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1516483004/20001
5 years ago (2015-12-09 19:40:58 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 19:50:39 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-09 19:51:30 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e86f046bdf3df1b37189a7204095ddfa837963f
Cr-Commit-Position: refs/heads/master@{#364131}

Powered by Google App Engine
This is Rietveld 408576698