Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: build/config/sysroot.gni

Issue 1516483004: GN: error out if attempting to use_sysroot with gcc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@arm_gn
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sysroot.gni
diff --git a/build/config/sysroot.gni b/build/config/sysroot.gni
index 2ca64518f6e23722d22fab6e6d31d01d2a074995..29a2b6117a30cb77da72b2ff24773f8d925d4b13 100644
--- a/build/config/sysroot.gni
+++ b/build/config/sysroot.gni
@@ -50,6 +50,12 @@ if (current_toolchain == default_toolchain && target_sysroot != "") {
}
if (sysroot != "") {
+ # Our sysroot images only contains gcc 4.6 headers, but chromium requires
+ # gcc 4.9. Clang is able to detect and work with the 4.6 headers while
+ # gcc is not. This check can be removed if we ever update to a more modern
+ # sysroot.
+ assert(is_clang, "sysroot images require clang (try use_sysroot=false)")
+
_script_arch = current_cpu
if (_script_arch == "x86") {
_script_arch = "i386"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698