Issue 1516473002: CombinatorContributor and LibraryMemberContributor - consolidate common behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1516473002: CombinatorContributor and LibraryMemberContributor - consolidate common behavior (Closed)

Created:
5 years ago by danrubel

Modified:
5 years ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -125 lines)			Patch
M	pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart	View	2 chunks	+8 lines, -96 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart	View	4 chunks	+6 lines, -28 lines	0 comments	Download

Total messages: 5 (2 generated)

danrubel

5 years ago (2015-12-09 16:41:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
87ac33a904bb843c51c698328164a2bae9714ab8 (presubmit successful).