pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart - Issue 1516473002: CombinatorContributor and LibraryMemberContributor - consolidate common behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart

Issue 1516473002: CombinatorContributor and LibraryMemberContributor - consolidate common behavior (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart

index cba3bd4c44181273c0bcfd17b120dae68e542435..8696b924d64942b53664d32ccc20830554e85b3b 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart

@@ -47,7 +47,7 @@ class CombinatorContributor extends DartCompletionContributor {

if (library != null) {

LibraryElementSuggestionBuilder builder =

new LibraryElementSuggestionBuilder(

- request, CompletionSuggestionKind.IDENTIFIER, false, false);

+ library, CompletionSuggestionKind.IDENTIFIER, false, false);

library.visitChildren(builder);

return builder.suggestions;

}

« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart » ('j') | no next file with comments »