Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6489)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator.cc

Issue 15163003: Don't open Chrome browser window on first login of a new user. Because it will hide Getting Started… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/startup_browser_creator.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator.cc b/chrome/browser/ui/startup/startup_browser_creator.cc
index 62af691e8d513b171da28fa6acfe728f11c30ed1..f5b635b9b2582b2605a06f33c07f018f82d94602 100644
--- a/chrome/browser/ui/startup/startup_browser_creator.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator.cc
@@ -252,6 +252,20 @@ bool StartupBrowserCreator::LaunchBrowser(
chrome::startup::IsProcessStartup process_startup,
chrome::startup::IsFirstRun is_first_run,
int* return_code) {
+
+#if defined(OS_CHROMEOS)
+ // Don't open default Chrome window for the first login of a new
+ // user because it will hide the Getting Started App window (which is
+ // launched automatically in that situation).
+ //
+ // Note: Ideally this check should be put in ProcessCmdLineImpl()
+ // before calling this function. However, chromeos/login/login_utils.cc
+ // calls this function directly (see comments there) so I have to get it
+ // down here.
+ if (chromeos::UserManager::Get()->IsCurrentUserNew())
+ return true;
+#endif
+
in_synchronous_profile_launch_ =
process_startup == chrome::startup::IS_PROCESS_STARTUP;
DCHECK(profile);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698