Don't open Chrome browser window on first login of a new user. Because it will hide Getting Started…

chrome/browser/ui/startup/startup_browser_creator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/startup_browser_creator.h"
 
 #include <algorithm>   // For max().
 #include <set>
 
 #include "base/bind.h"
@@ skipping 234 matching lines @@
   return in_synchronous_profile_launch_;
 }
 
 bool StartupBrowserCreator::LaunchBrowser(
     const CommandLine& command_line,
     Profile* profile,
     const base::FilePath& cur_dir,
     chrome::startup::IsProcessStartup process_startup,
     chrome::startup::IsFirstRun is_first_run,
     int* return_code) {
+
+#if defined(OS_CHROMEOS)
+  // Don't open default Chrome window for the first login of a new
+  // user because it will hide the Getting Started App window (which is
+  // launched automatically in that situation).
+  //
+  // Note: Ideally this check should be put in ProcessCmdLineImpl()
+  // before calling this function. However, chromeos/login/login_utils.cc
+  // calls this function directly (see comments there) so I have to get it
+  // down here.
+  if (chromeos::UserManager::Get()->IsCurrentUserNew())
+    return true;
+#endif
+
   in_synchronous_profile_launch_ =
       process_startup == chrome::startup::IS_PROCESS_STARTUP;
   DCHECK(profile);
 
   // Continue with the incognito profile from here on if Incognito mode
   // is forced.
   if (IncognitoModePrefs::ShouldLaunchIncognito(command_line,
                                                 profile->GetPrefs())) {
     profile = profile->GetOffTheRecordProfile();
   } else if (command_line.HasSwitch(switches::kIncognito)) {
@@ skipping 311 matching lines @@
 
   if (chrome::IsRunningInAppMode() &&
       command_line.HasSwitch(switches::kAppId)) {
     // StartupAppLauncher deletes itself when done.
     (new chromeos::StartupAppLauncher(
         last_used_profile,
         command_line.GetSwitchValueASCII(switches::kAppId)))->Start();
 
     // Skip browser launch since app mode launches its app window.
     silent_launch = true;
   }

[sky, 2013/05/15 15:21:55]

Can you do your check here instead and set silent_launch to true?

[cylee1, 2013/05/15 18:10:44]

That was my first try. But somewhere in  chromeos/login/login_utils.cc calls
StartupBrowserCreator::LaunchBrowser() directly instead of this function.

 #endif
 
 #if defined(TOOLKIT_VIEWS) && defined(USE_X11)
   ui::TouchFactory::SetTouchDeviceListFromCommandLine();
 #endif
 
   // If we don't want to launch a new browser window or tab (in the case
   // of an automation request), we are done here.
   if (silent_launch)
     return true;
@@ skipping 124 matching lines @@
 
 // static
 bool StartupBrowserCreator::ActivatedProfile() {
   return profile_launch_observer.Get().activated_profile();
 }
 
 bool HasPendingUncleanExit(Profile* profile) {
   return profile->GetLastSessionExitType() == Profile::EXIT_CRASHED &&
       !profile_launch_observer.Get().HasBeenLaunched(profile);
 }