Don't open Chrome browser window on first login of a new user. Because it will hide Getting Started…

chrome/browser/ui/startup/startup_browser_creator.cc

Index: chrome/browser/ui/startup/startup_browser_creator.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator.cc b/chrome/browser/ui/startup/startup_browser_creator.cc
index 62af691e8d513b171da28fa6acfe728f11c30ed1..2371ea12d36c766950a30bbfd1384b7de6cc978b 100644
--- a/chrome/browser/ui/startup/startup_browser_creator.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator.cc
@@ -252,6 +252,21 @@ bool StartupBrowserCreator::LaunchBrowser(
     chrome::startup::IsProcessStartup process_startup,
     chrome::startup::IsFirstRun is_first_run,
     int* return_code) {
+
+#if defined(OS_CHROMEOS)
+  // Not to open default Chrome window for the first login of a new

[Finnur, 2013/05/15 10:24:33]

nit: Not to open -> Don't open

[cylee1, 2013/05/15 13:39:49]

Done.

+  // user because it will hide the Getting Started App window (which is
+  // launched automatically in that situation).
+  //
+  // Note(cylee): Ideally this check should be put in ProcessCmdLineImpl()

[Finnur, 2013/05/15 10:24:33]

style: Note(cylee) is not something we use. Use either:

Note: Ideally...
or
TODO(cylee): Find a way to put this check in ProcessCmdLineImpl()...

It sounds like you want the former.

[cylee1, 2013/05/15 13:39:49]

Done.

+  // before calling this function. However in chromeos/login/login_utils.cc

[Finnur, 2013/05/15 10:24:33]

nit: suggest rewording: "However, chromeos/login/login_utils.cc calls this
function directly..."

[cylee1, 2013/05/15 13:39:49]

Done.

+  // it directly calls this function (see comments there) so I have to get it
+  // down here.
+  if (chromeos::UserManager::Get()->IsCurrentUserNew()) {
+    return true;
+  }

[Finnur, 2013/05/15 10:24:33]

style: No braces around single line if clauses.

[cylee1, 2013/05/15 13:39:49]

Done.

+#endif
+

[Finnur, 2013/05/15 10:24:33]

nit: Also, suggest changing 'hind'->'hide' in the CL description

[cylee1, 2013/05/15 13:39:49]

Done.

   in_synchronous_profile_launch_ =
       process_startup == chrome::startup::IS_PROCESS_STARTUP;
   DCHECK(profile);