Don't open Chrome browser window on first login of a new user. Because it will hide Getting Started…

chrome/browser/ui/startup/startup_browser_creator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/startup_browser_creator.h"
 
 #include <algorithm>   // For max().
 #include <set>
 
 #include "base/bind.h"
@@ skipping 234 matching lines @@
   return in_synchronous_profile_launch_;
 }
 
 bool StartupBrowserCreator::LaunchBrowser(
     const CommandLine& command_line,
     Profile* profile,
     const base::FilePath& cur_dir,
     chrome::startup::IsProcessStartup process_startup,
     chrome::startup::IsFirstRun is_first_run,
     int* return_code) {
+
+#if defined(OS_CHROMEOS)
+  // Not to open default Chrome window for the first login of a new

[Finnur, 2013/05/15 10:24:33]

nit: Not to open -> Don't open

[cylee1, 2013/05/15 13:39:49]

Done.

+  // user because it will hide the Getting Started App window (which is
+  // launched automatically in that situation).
+  //
+  // Note(cylee): Ideally this check should be put in ProcessCmdLineImpl()

[Finnur, 2013/05/15 10:24:33]

style: Note(cylee) is not something we use. Use either:

Note: Ideally...
or
TODO(cylee): Find a way to put this check in ProcessCmdLineImpl()...

It sounds like you want the former.

[cylee1, 2013/05/15 13:39:49]

Done.

+  // before calling this function. However in chromeos/login/login_utils.cc

[Finnur, 2013/05/15 10:24:33]

nit: suggest rewording: "However, chromeos/login/login_utils.cc calls this
function directly..."

[cylee1, 2013/05/15 13:39:49]

Done.

+  // it directly calls this function (see comments there) so I have to get it
+  // down here.
+  if (chromeos::UserManager::Get()->IsCurrentUserNew()) {
+    return true;
+  }

[Finnur, 2013/05/15 10:24:33]

style: No braces around single line if clauses.

[cylee1, 2013/05/15 13:39:49]

Done.

+#endif
+

[Finnur, 2013/05/15 10:24:33]

nit: Also, suggest changing 'hind'->'hide' in the CL description

[cylee1, 2013/05/15 13:39:49]

Done.

   in_synchronous_profile_launch_ =
       process_startup == chrome::startup::IS_PROCESS_STARTUP;
   DCHECK(profile);
 
   // Continue with the incognito profile from here on if Incognito mode
   // is forced.
   if (IncognitoModePrefs::ShouldLaunchIncognito(command_line,
                                                 profile->GetPrefs())) {
     profile = profile->GetOffTheRecordProfile();
   } else if (command_line.HasSwitch(switches::kIncognito)) {
@@ skipping 456 matching lines @@
 
 // static
 bool StartupBrowserCreator::ActivatedProfile() {
   return profile_launch_observer.Get().activated_profile();
 }
 
 bool HasPendingUncleanExit(Profile* profile) {
   return profile->GetLastSessionExitType() == Profile::EXIT_CRASHED &&
       !profile_launch_observer.Get().HasBeenLaunched(profile);
 }