Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1515993003: Use AVDA copying strategy unless the unified pipeline flag is set. (Closed)

Created:
5 years ago by liberato (no reviews please)
Modified:
5 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use AVDA copying strategy unless the unified pipeline flag is set. Cause AVDA to use the copying strategy unless the right #defines and runtime flags are provided to enable it. We want to prevent WebRTC from using the unfinished deferred rendering strategy, unless the unifed media pipeline runtime flag is present to enable it. BUG=565561 Committed: https://crrev.com/2ac89ad12d6f0c914c673e57299f69e6d2046941 Cr-Commit-Position: refs/heads/master@{#365596}

Patch Set 1 #

Patch Set 2 : added flag to gpu process. #

Patch Set 3 : added #ifdef android #

Total comments: 2

Patch Set 4 : cl feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/gpu/media/android_copying_backing_strategy.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/gpu/media/android_deferred_rendering_backing_strategy.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.cc View 1 2 3 6 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
DaleCurtis
lgtm % nit -- going to need this to switch to runtime flags. https://codereview.chromium.org/1515993003/diff/40001/content/common/gpu/media/android_video_decode_accelerator.cc File ...
5 years ago (2015-12-15 23:42:57 UTC) #2
liberato (no reviews please)
kbr@: can you PTAL at gpu_process_host.cc? thanks -fl https://codereview.chromium.org/1515993003/diff/40001/content/common/gpu/media/android_video_decode_accelerator.cc File content/common/gpu/media/android_video_decode_accelerator.cc (right): https://codereview.chromium.org/1515993003/diff/40001/content/common/gpu/media/android_video_decode_accelerator.cc#newcode696 content/common/gpu/media/android_video_decode_accelerator.cc:696: if ...
5 years ago (2015-12-16 16:11:05 UTC) #5
Ken Russell (switch to Gerrit)
gpu_process_host lgtm
5 years ago (2015-12-16 18:31:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515993003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515993003/60001
5 years ago (2015-12-16 18:34:39 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-16 20:00:23 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-16 20:01:09 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2ac89ad12d6f0c914c673e57299f69e6d2046941
Cr-Commit-Position: refs/heads/master@{#365596}

Powered by Google App Engine
This is Rietveld 408576698