Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 15159008: Node::lazyAttach shouldn't lie about being attached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase again Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLPlugInImageElement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLSelectElement.cpp
diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp
index 01f61415518e9deebd89870d00a20b9b447ce096..6ce29fefb94516fda66069cd550b6343ea993109 100644
--- a/Source/core/html/HTMLSelectElement.cpp
+++ b/Source/core/html/HTMLSelectElement.cpp
@@ -307,6 +307,9 @@ void HTMLSelectElement::parseAttribute(const QualifiedName& name, const AtomicSt
m_size = size;
setNeedsValidityCheck();
if (m_size != oldSize && attached()) {
+ // FIXME: setRecalcListItems uses the renderer to decide if we should update
+ // the accessibility tree so we can't lazyAttach. That code should be moved
+ // out of setRecalcListItems.
reattach();
setRecalcListItems();
}
« no previous file with comments | « Source/core/html/HTMLPlugInImageElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698