Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: Source/core/html/HTMLSelectElement.cpp

Issue 15159008: Node::lazyAttach shouldn't lie about being attached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase again Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLPlugInImageElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * 10 *
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 } 300 }
301 size = max(size, 1); 301 size = max(size, 1);
302 302
303 // Ensure that we've determined selectedness of the items at least once prior to changing the size. 303 // Ensure that we've determined selectedness of the items at least once prior to changing the size.
304 if (oldSize != size) 304 if (oldSize != size)
305 updateListItemSelectedStates(); 305 updateListItemSelectedStates();
306 306
307 m_size = size; 307 m_size = size;
308 setNeedsValidityCheck(); 308 setNeedsValidityCheck();
309 if (m_size != oldSize && attached()) { 309 if (m_size != oldSize && attached()) {
310 // FIXME: setRecalcListItems uses the renderer to decide if we shoul d update
311 // the accessibility tree so we can't lazyAttach. That code should b e moved
312 // out of setRecalcListItems.
310 reattach(); 313 reattach();
311 setRecalcListItems(); 314 setRecalcListItems();
312 } 315 }
313 } else if (name == multipleAttr) 316 } else if (name == multipleAttr)
314 parseMultipleAttribute(value); 317 parseMultipleAttribute(value);
315 else if (name == accesskeyAttr) { 318 else if (name == accesskeyAttr) {
316 // FIXME: ignore for the moment. 319 // FIXME: ignore for the moment.
317 // 320 //
318 } else 321 } else
319 HTMLFormControlElementWithState::parseAttribute(name, value); 322 HTMLFormControlElementWithState::parseAttribute(name, value);
(...skipping 1248 matching lines...) Expand 10 before | Expand all | Expand 10 after
1568 } 1571 }
1569 1572
1570 void HTMLSelectElement::finishParsingChildren() 1573 void HTMLSelectElement::finishParsingChildren()
1571 { 1574 {
1572 HTMLFormControlElementWithState::finishParsingChildren(); 1575 HTMLFormControlElementWithState::finishParsingChildren();
1573 m_isParsingInProgress = false; 1576 m_isParsingInProgress = false;
1574 updateListItemSelectedStates(); 1577 updateListItemSelectedStates();
1575 } 1578 }
1576 1579
1577 } // namespace 1580 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLPlugInImageElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698