Source/core/dom/shadow/ElementShadow.cpp - Issue 15159008: Node::lazyAttach shouldn't lie about being attached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/ElementShadow.cpp

Issue 15159008: Node::lazyAttach shouldn't lie about being attached (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase again Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/shadow/ElementShadow.cpp

diff --git a/Source/core/dom/shadow/ElementShadow.cpp b/Source/core/dom/shadow/ElementShadow.cpp

index ec30bd6535872d8ca0034ea802178af075185b1e..3bc753a92e53bcb3f82a412dd2cac4d29d2fa004 100644

--- a/Source/core/dom/shadow/ElementShadow.cpp

+++ b/Source/core/dom/shadow/ElementShadow.cpp

@@ -44,9 +44,6 @@ ShadowRoot* ElementShadow::addShadowRoot(Element* shadowHost, ShadowRoot::Shadow

// Existence of shadow roots requires the host and its children to do traversal using ComposedShadowTreeWalker.

shadowHost->setNeedsShadowTreeWalker();

- // FIXME(94905): ShadowHost should be reattached during recalcStyle.

- // Set some flag here and recreate shadow hosts' renderer in

- // Element::recalcStyle.

if (shadowHost->attached())

shadowHost->lazyReattach();

« no previous file with comments | « Source/core/dom/Text.cpp ('k') | Source/core/dom/shadow/ShadowRoot.cpp » ('j') | no next file with comments »