Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: Source/core/dom/shadow/ShadowRoot.cpp

Issue 15159008: Node::lazyAttach shouldn't lie about being attached (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase again Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/shadow/ElementShadow.cpp ('k') | Source/core/html/HTMLDialogElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/shadow/ShadowRoot.cpp
diff --git a/Source/core/dom/shadow/ShadowRoot.cpp b/Source/core/dom/shadow/ShadowRoot.cpp
index 06189b27216ea289b53758d72bdaf218a040e7bb..fcf17567dd4be791c54bc3fef5220cd24cd6b8cd 100644
--- a/Source/core/dom/shadow/ShadowRoot.cpp
+++ b/Source/core/dom/shadow/ShadowRoot.cpp
@@ -142,6 +142,12 @@ void ShadowRoot::recalcStyle(StyleChange change)
StyleResolver* styleResolver = document()->styleResolver();
styleResolver->pushParentShadowRoot(this);
+ // When we're set to lazyAttach we'll have a FullStyleChange and we'll need
+ // to promote the change to a Force for all our descendants so they get a
+ // recalc and will attach.
+ if (styleChangeType() == FullStyleChange)
+ change = Force;
+
for (Node* child = firstChild(); child; child = child->nextSibling()) {
if (child->isElementNode())
toElement(child)->recalcStyle(change);
« no previous file with comments | « Source/core/dom/shadow/ElementShadow.cpp ('k') | Source/core/html/HTMLDialogElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698